Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cloud scripts #4115

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Fix/cloud scripts #4115

merged 2 commits into from
Oct 19, 2023

Conversation

bxy4543
Copy link
Member

@bxy4543 bxy4543 commented Oct 19, 2023

πŸ€– Generated by Copilot at 2f00654

Summary

πŸ—οΈπŸš€πŸ› οΈ

This pull request enhances the sealos cloud installation and the cross-platform build process. It adds the TARGETARCH variable to the make build command in .github/workflows/controllers.yml to ensure binary compatibility. It also improves the install.sh script in scripts/cloud/install.sh by adding local installation support, updating the image version, and adding more prompts, checks, and optimizations.

We build the sealos cloud with TARGETARCH
We defy the platform limits with our code and our march
We install the script with local and remote options
We optimize the image and the storage with our actions

Walkthrough

  • Add TARGETARCH environment variable to make build command for amd64 and arm64 architectures (link, link)
  • Update CLOUD_VERSION variable to use latest tag instead of fixed version (link)
  • Add local_install variable to indicate single node or multiple node installation (link, link, link)
  • Add pre_prompt and pull_image prompts to inform user of dependencies and image pulling progress (link, link)
  • Remove unnecessary sentence from patching_ingress prompt (link)
  • Add error handling for grep avx /proc/cpuinfo command and set mongodb_version accordingly (link)
  • Pull images before installation with sealos pull command to avoid timeouts or errors (link)
  • Expand --masters and --nodes flags only if variables are not empty and use default values for subnets if variables are empty (link, link)
  • Suppress output and errors of command -v and source commands (link, link, link)
  • Group get_prompt and sealos apply commands in subshell and inform user of Kubernetes cluster installation (link)
  • Check if openebs-backup storage class exists and create it if not (link)

optimize pull image before;
fix controller TARGETARCH
@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 952
βœ… Successful 371
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 580
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@sweep-ai
Copy link

sweep-ai bot commented Oct 19, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests βœ…

πŸ“’ Thoughts on this report? Let us know!.

@bxy4543 bxy4543 added this to the v5.0 milestone Oct 19, 2023
@bxy4543 bxy4543 requested a review from lingdie October 19, 2023 08:14
@lingdie lingdie merged commit 00726c6 into labring:main Oct 19, 2023
68 checks passed
@bxy4543 bxy4543 deleted the fix/cloud_scripts branch October 19, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants